Make Plex Wish List sync one-way (add-only) and fix silent-failure logging #44
No reviewers
Labels
No labels
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
WulfScience-FOSS/ha-music-own!44
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "macsome_3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Verified against Music Assistant's own source: the Apple Music provider's
remove_playlist_tracks unconditionally raises ("Removing tracks from
playlists is not supported by the Apple Music API. Make sure to delete
them using the Apple Music app."), so the previous add+remove design could
never actually remove anything - it would just fail and log a warning every
sync. sync_wishlist_playlist now only adds, and reports a "stale" count
(tracks that are no longer wanted but can't be auto-removed) via
sensor.plex_wish_list's new stale_needs_manual_removal attribute instead.
Also fixes a real observability gap: fetch_ma_playlists and
sync_wishlist_playlist could both return without logging anything in some
branches, making a "wishlist playlist not found" case indistinguishable
from "found but nothing to do" by log inspection alone. Both paths now log
unconditionally. Also documented that Music Assistant does not appear to
index empty playlists into its library - the wishlist playlist needs at
least one track before it'll ever be picked up by get_library_playlists().
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Verified against Music Assistant's own source: the Apple Music provider's remove_playlist_tracks unconditionally raises ("Removing tracks from playlists is not supported by the Apple Music API. Make sure to delete them using the Apple Music app."), so the previous add+remove design could never actually remove anything - it would just fail and log a warning every sync. sync_wishlist_playlist now only adds, and reports a "stale" count (tracks that are no longer wanted but can't be auto-removed) via sensor.plex_wish_list's new stale_needs_manual_removal attribute instead. Also fixes a real observability gap: fetch_ma_playlists and sync_wishlist_playlist could both return without logging anything in some branches, making a "wishlist playlist not found" case indistinguishable from "found but nothing to do" by log inspection alone. Both paths now log unconditionally. Also documented that Music Assistant does not appear to index empty playlists into its library - the wishlist playlist needs at least one track before it'll ever be picked up by get_library_playlists(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>