Wait for each Plex Wish List add batch to actually finish before sending the next #49

Merged

neerdoc merged 1 commit from macsome_8 into main

2026-07-28 20:02:25 +00:00

neerdoc commented

2026-07-28 20:02:18 +00:00

Owner

The server does return that BackgroundTask (with an id we can poll via
tasks/get, Scope.SYSTEM_READ) - the music_assistant_client wrapper we were
calling just discards it and returns None. Now calls client.send_command
directly to get the task id back, then polls tasks/get until the task
reaches a real terminal status (success/partial_success/failed/cancelled)
before moving to the next batch, and reports accurate added/failed counts
based on the task's actual outcome instead of assuming success whenever
the initial RPC call didn't raise.

Falls back to the old assume-success behavior if the server response
doesn't include a task id (older MA versions), and if tasks/get itself
fails (e.g. the configured MA token lacks permission), the batch is
counted as failed rather than crashing the sync.

Chunking into batches of 25 (previous commit) wasn't enough on its own: live logs showed a 496-track add reporting success in ~20 seconds, while Music Assistant's own background-tasks view showed multiple "Add items to playlist" tasks still queued/running well after our sync had already finished. Confirmed in MA's own server source (controllers/music/media/playlists.py): add_playlist_tracks queues a managed background task and returns immediately without awaiting it - `return self.mass.tasks.run_background_task(...)`. Firing 20 batches ~1s apart queued a backlog faster than MA could actually process it. The server does return that BackgroundTask (with an id we can poll via tasks/get, Scope.SYSTEM_READ) - the music_assistant_client wrapper we were calling just discards it and returns None. Now calls client.send_command directly to get the task id back, then polls tasks/get until the task reaches a real terminal status (success/partial_success/failed/cancelled) before moving to the next batch, and reports accurate added/failed counts based on the task's actual outcome instead of assuming success whenever the initial RPC call didn't raise. Falls back to the old assume-success behavior if the server response doesn't include a task id (older MA versions), and if tasks/get itself fails (e.g. the configured MA token lacks permission), the batch is counted as failed rather than crashing the sync.

neerdoc added 1 commit

2026-07-28 20:02:18 +00:00

Wait for each Plex Wish List add batch to actually finish before sending the next edd5dda1cc

Chunking into batches of 25 (previous commit) wasn't enough on its own:
live logs showed a 496-track add reporting success in ~20 seconds, while
Music Assistant's own background-tasks view showed multiple "Add items to
playlist" tasks still queued/running well after our sync had already
finished. Confirmed in MA's own server source
(controllers/music/media/playlists.py): add_playlist_tracks queues a
managed background task and returns immediately without awaiting it -
`return self.mass.tasks.run_background_task(...)`. Firing 20 batches ~1s
apart queued a backlog faster than MA could actually process it.

The server does return that BackgroundTask (with an id we can poll via
tasks/get, Scope.SYSTEM_READ) - the music_assistant_client wrapper we were
calling just discards it and returns None. Now calls client.send_command
directly to get the task id back, then polls tasks/get until the task
reaches a real terminal status (success/partial_success/failed/cancelled)
before moving to the next batch, and reports accurate added/failed counts
based on the task's actual outcome instead of assuming success whenever
the initial RPC call didn't raise.

Falls back to the old assume-success behavior if the server response
doesn't include a task id (older MA versions), and if tasks/get itself
fails (e.g. the configured MA token lacks permission), the batch is
counted as failed rather than crashing the sync.

neerdoc merged commit 02b1d88c71 into main

2026-07-28 20:02:25 +00:00

neerdoc referenced this pull request from a commit

2026-07-28 20:02:26 +00:00

Merge pull request 'Wait for each Plex Wish List add batch to actually finish before sending the next' (#49) from macsome_8 into main